Cleanup import statements #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mio once started with the order of std, external crates, than crate internal imports. At some points this order was not enforce properly and we ended up with a mix imports statements. This commit orders everything following imports from std, external crates, then crate internal (the `group_imports="StdExternalCrate"` rustfmt option). This has no functional change.
Darksonn
approved these changes
Dec 31, 2023
| pub(crate) use self::epoll::{event, Event, Events, Selector}; | ||
| pub(crate) use epoll::{event, Event, Events, Selector}; |
There was a problem hiding this comment.
I would probably have kept the self:: markers.
There was a problem hiding this comment.
They're not needed any more since rust edition 2018/2021, so I the code I write now I never use it any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mio once started with the order of std, external crates, than crate internal imports. At some points this order was not enforce properly and we ended up with a mix imports statements.
This commit orders everything following imports from std, external crates, then crate internal (the
group_imports="StdExternalCrate"rustfmt option).This has no functional change.
This has been annoying me for a while, so I decide to fix all of it in one fell swoop.
Depends on #1745