Implement I/O safety traits #1745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2023
Darksonn
reviewed
Dec 31, 2023
Comment on lines
-22
to
+24
| #[cfg(unix)] | ||
| use std::os::unix::io::FromRawFd; | ||
| #[cfg(target_os = "wasi")] | ||
| use std::os::wasi::io::FromRawFd; | ||
| #[cfg(any(unix, target_os = "wasi"))] | ||
| use std::os::fd::FromRawFd; |
There was a problem hiding this comment.
This module is rather new, so this change may conflict with decreasing the MSRV as discussed in #1732. Maybe just introduce your own module for this functionality?
There was a problem hiding this comment.
std::os::fd is from Rust 1.66, in #1749 we'll need a MSRV of 1.71 (?), so this won't make the difference.
Co-authored-by: ssrlive <[email protected]>
Instead of std::os::unix. It also works on WASM/WASI.
The AsFd, AsRawFd, FromRawFd and IntoRawFd traits. For WASI this was not implemented for all public types, now it is (matching Unix).
Mio once started with the order of std, external crates, than crate internal imports. At some points this order was not enforce properly and we ended up with a mix imports statements. This commit orders everything following imports from std, external crates, then crate internal (the `group_imports="StdExternalCrate"` rustfmt option). This has no functional change.
Thomasdezeeuw
force-pushed
the
thomas/1588
branch
from
ba9fa9f
to
ea72027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1588