chore(deps): bump tonic to 0.11 and raise MSRV to 1.70 #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hds
requested changes
Apr 20, 2024
There was a problem hiding this comment.
By bumping to a semver incompatible version of tonic, this change needs to be marked as incompatible in the commit message (https://www.conventionalcommits.org/en/v1.0.0/).
Also, the console-api protobuf files need to be updated, as do the ones console-subscriber grpc web example.
For console-api the following command needs to be run:
cargo run -p xtask -- gen-protoFor the example, the instructions are here:
https://github.com/tokio-rs/console/tree/main/console-subscriber/examples/grpc_web#understanding-the-code
BREAKING CHANGE: This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.10.x.
|
Hello, I came across this PR because |
|
@hds Could you please help approve this PR? Then we can merge it. Thanks! |
hds
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.