Update README.md #510
Merged
Update README.md #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-rustin
requested changes
Jan 21, 2024
SimonsMine
commented
Jan 21, 2024
|
fixed : ) |
hawkw
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Thanks for helping to improve the documentation!
I suggested some edits to the note on UTF-8 support, let me know what you think?
Also, would you mind adding a similar note to the tokio-console crate's README, in the "running the console" section? That documentation is rendered on https://crates.io/crates/tokio-console and https://docs.rs/tokio-console, so it would be nice to include the Windows support information there as well.
|
Applied suggestions : ) |
hawkw
approved these changes
Feb 6, 2024
hi-rustin
approved these changes
May 23, 2024
Added note about windows
Co-authored-by: Eliza Weisman <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note about windows