Introduce SharedBuf trait for Bytes VTable #596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to continue the work of PR #567. This updates the code to be more conformant to the idioms of Rust and the Tokio project.
The work in #567 introduces a new trait which is used as a contract for internal and external structs to make themselves usable as the internal buffer for
Bytes
.This should solve the current issues that request a mechanism for allowing a Bytes struct to own arbitrary 3rd party buffers. see: #437 #526 #571
This would allow an arbitrary buffer to be converted into a Bytes buffer (using the new Bytes::from_shared_buf method) and later be converted back to the original type, consuming the buffer (using Bytes::into_shared_buf method)
An example of this can be found here
Specific changes from #567:
BytesImpl
intoSharedBuf
.SharedBuf
and moves them into their own module.SharedBuf
trait can be implemented by 3rd party devs.SharedBuf
implementation with tests.Due to re-organizing the SharedBuf implementations, this makes things a bit harder to diff, but the functionality of Bytes itself is almost completely unchanged. All tests pass, and the benchmarks are equivalent within a reasonable deviation (using
cargo benchcmp
)For more precise deltas between the code, you can look at the commit progression in #567