Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add version check to sign in #9219

Open
wants to merge 2 commits into
base: darksky/version-check
Choose a base branch
from

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Dec 20, 2024

No description provided.

@JimmFly JimmFly marked this pull request as ready for review December 20, 2024 04:28
@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Dec 20, 2024
Copy link
Member Author

JimmFly commented Dec 20, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JimmFly JimmFly requested a review from darkskygit December 20, 2024 04:28
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.75%. Comparing base (6a54784) to head (3cb620d).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           darksky/version-check    #9219      +/-   ##
=========================================================
- Coverage                  65.80%   65.75%   -0.05%     
=========================================================
  Files                        734      734              
  Lines                      41699    41699              
  Branches                    4141     4141              
=========================================================
- Hits                       27439    27421      -18     
- Misses                     13821    13839      +18     
  Partials                     439      439              
Flag Coverage Δ
server-test 78.38% <ø> (-0.07%) ⬇️
unittest 35.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly requested a review from forehalo December 20, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants