Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): explorer create/rename operation #8628

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Oct 29, 2024

close AF-1560

Copy link

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

CatsJuice commented Oct 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice marked this pull request as ready for review October 29, 2024 08:30
@graphite-app graphite-app bot requested review from EYHN, forehalo, pengx17 and JimmFly and removed request for EYHN October 29, 2024 08:30
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-explorer-operation branch from 51a495c to 26b2415 Compare October 29, 2024 08:33
Copy link

nx-cloud bot commented Oct 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 78eaf78. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.10%. Comparing base (1f6cce2) to head (78eaf78).

Files with missing lines Patch % Lines
...ages/frontend/component/src/ui/menu/mobile/hook.ts 20.00% 4 Missing ⚠️
...ges/frontend/component/src/ui/menu/mobile/root.tsx 0.00% 1 Missing ⚠️
...ages/frontend/component/src/ui/menu/mobile/sub.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8628      +/-   ##
==========================================
+ Coverage   70.06%   70.10%   +0.04%     
==========================================
  Files         542      543       +1     
  Lines       33764    33770       +6     
  Branches     3034     3035       +1     
==========================================
+ Hits        23656    23675      +19     
+ Misses       9751     9738      -13     
  Partials      357      357              
Flag Coverage Δ
server-test 77.09% <ø> (+0.06%) ⬆️
unittest 45.14% <14.28%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the test Related to test cases label Oct 30, 2024
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-explorer-operation branch from ba03769 to acf575b Compare October 31, 2024 01:24
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-explorer-operation branch from acf575b to 666a6cc Compare October 31, 2024 11:01
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-explorer-operation branch from 666a6cc to 9b09a3d Compare November 1, 2024 02:16
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-explorer-operation branch from 9b09a3d to f328963 Compare November 1, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:component mod:i18n Related to i18n test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant