Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add edgelessTheme property and edgelessDefault theme setting #8614

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Oct 28, 2024

close AF-1430 AF-1471

CleanShot.2024-10-28.at.16.36.40.mp4

Copy link

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:i18n Related to i18n app:core labels Oct 28, 2024
Copy link
Member Author

JimmFly commented Oct 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Oct 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 10b1f23. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.10%. Comparing base (1f6cce2) to head (10b1f23).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/infra/src/index.ts 0.00% 1 Missing ⚠️
...s/common/infra/src/modules/theme/entities/theme.ts 0.00% 1 Missing ⚠️
packages/common/infra/src/modules/theme/index.ts 0.00% 1 Missing ⚠️
...s/common/infra/src/modules/theme/services/theme.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8614      +/-   ##
==========================================
+ Coverage   70.06%   70.10%   +0.04%     
==========================================
  Files         542      545       +3     
  Lines       33764    33768       +4     
  Branches     3034     3034              
==========================================
+ Hits        23656    23674      +18     
+ Misses       9751     9737      -14     
  Partials      357      357              
Flag Coverage Δ
server-test 77.09% <ø> (+0.06%) ⬆️
unittest 45.14% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the test Related to test cases label Oct 28, 2024
@JimmFly JimmFly changed the title feat(core): add edgelessTheme property feat(core): add edgelessTheme property and edgelessDefault theme setting Oct 28, 2024
@JimmFly JimmFly marked this pull request as ready for review October 28, 2024 08:25
@graphite-app graphite-app bot requested a review from forehalo October 28, 2024 08:26
Copy link
Member

@forehalo forehalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use stable bs

Copy link

graphite-app bot commented Nov 1, 2024

Merge activity

  • Oct 31, 11:57 PM EDT: A user added this pull request to the Graphite merge queue.
  • Nov 1, 12:13 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'E2E Mobile Test (1)').
  • Nov 1, 12:44 AM EDT: A user added this pull request to the Graphite merge queue.
  • Nov 1, 12:45 AM EDT: A user merged this pull request with the Graphite merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:component mod:dev mod:env mod:i18n Related to i18n mod:infra Environment related issues and discussions test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants