Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add enable cloud failed notify #6741

Merged
merged 1 commit into from Apr 30, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Apr 29, 2024

No description provided.

Copy link

graphite-app bot commented Apr 29, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review April 29, 2024 12:03
Copy link
Member Author

EYHN commented Apr 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 64.91%. Comparing base (148e058) to head (764da78).

Files Patch % Lines
...rontend/core/src/hooks/affine/use-enable-cloud.tsx 0.00% 7 Missing ⚠️
.../frontend/component/src/ui/modal/confirm-modal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6741      +/-   ##
==========================================
- Coverage   64.92%   64.91%   -0.01%     
==========================================
  Files         580      580              
  Lines       27193    27197       +4     
  Branches     2433     2433              
==========================================
  Hits        17655    17655              
- Misses       9273     9277       +4     
  Partials      265      265              
Flag Coverage Δ
server-test 74.68% <ø> (ø)
unittest 40.34% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN requested review from CatsJuice and pengx17 April 30, 2024 02:32
Copy link

graphite-app bot commented Apr 30, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/feat/enable-cloud-faile branch from 7e2f063 to 764da78 Compare April 30, 2024 04:47
@EYHN EYHN changed the base branch from eyhn/remove-unused-atom to canary April 30, 2024 04:56
@graphite-app graphite-app bot merged commit 764da78 into canary Apr 30, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/enable-cloud-faile branch April 30, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants