Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init ios-bridge #6696

Closed
wants to merge 1 commit into from
Closed

feat: init ios-bridge #6696

wants to merge 1 commit into from

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Apr 25, 2024

Create a new entry without UI, but expose some APIs on the window, and we can build a native iOS app based on these APIs.

CleanShot 2024-04-25 at 16.50.03.png

Copy link

graphite-app bot commented Apr 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Apr 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 25, 2024

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.36%. Comparing base (74b7d02) to head (3953103).
Report is 1 commits behind head on canary.

Files Patch % Lines
...s/frontend/core/src/modules/cloud/services/auth.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6696      +/-   ##
==========================================
- Coverage   61.42%   61.36%   -0.06%     
==========================================
  Files         586      586              
  Lines       26896    26891       -5     
  Branches     2356     2354       -2     
==========================================
- Hits        16520    16502      -18     
- Misses      10094    10107      +13     
  Partials      282      282              
Flag Coverage Δ
server-test 70.01% <ø> (-0.10%) ⬇️
unittest 41.61% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,52 @@
import './polyfill/dispose';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should rename to jsb rather than ios-bridge? maybe we can use it in android too

@EYHN EYHN closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants