Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add copilot impl #6230

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: add copilot impl #6230

merged 1 commit into from
Apr 10, 2024

Conversation

darkskygit
Copy link
Member

@darkskygit darkskygit commented Mar 20, 2024

fix CLOUD-22
fix CLOUD-24

Copy link

nx-cloud bot commented Mar 20, 2024

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 46.08696% with 186 lines in your changes are missing coverage. Please review.

Project coverage is 62.30%. Comparing base (46a368d) to head (e6a5765).

Files Patch % Lines
...end/server/src/plugins/copilot/providers/openai.ts 31.28% 134 Missing ⚠️
...ages/backend/server/src/plugins/copilot/session.ts 18.75% 52 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           darksky/copilot-session    #6230      +/-   ##
===========================================================
- Coverage                    62.46%   62.30%   -0.16%     
===========================================================
  Files                          521      522       +1     
  Lines                        24530    24860     +330     
  Branches                      2287     2295       +8     
===========================================================
+ Hits                         15322    15490     +168     
- Misses                        8936     9098     +162     
  Partials                       272      272              
Flag Coverage Δ
server-test 73.27% <45.29%> (-0.46%) ⬇️
unittest 38.82% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkskygit darkskygit changed the title feat: add openai impl feat: add copilot impl Mar 20, 2024
@toeverything toeverything deleted a comment from graphite-app bot Mar 20, 2024
@darkskygit darkskygit force-pushed the darksky/copilot-plugins branch 2 times, most recently from 6778933 to 8bb1833 Compare March 20, 2024 11:03
@darkskygit darkskygit changed the base branch from darksky/copilot-service-base to canary March 20, 2024 11:03
@darkskygit darkskygit changed the base branch from canary to darksky/copilot-service-base March 20, 2024 11:07
@darkskygit darkskygit changed the base branch from darksky/copilot-service-base to darksky/copilot-prompt March 21, 2024 07:02
@zkwolf
Copy link

zkwolf commented Mar 21, 2024

I think it's possible to have a less strict restriction on model names, so that in the future users can use some openai api-compatible services, such as ollama and groq.

@darkskygit
Copy link
Member Author

I think it's possible to have a less strict restriction on model names, so that in the future users can use some openai api-compatible services, such as ollama and groq.

will have another provider impl for that -- this will make the code more maintainable, although most of the logic and API are similar

@darkskygit darkskygit changed the base branch from darksky/copilot-prompt to darksky/copilot-session March 21, 2024 09:20
Copy link

graphite-app bot commented Apr 10, 2024

Merge activity

@darkskygit darkskygit changed the base branch from darksky/copilot-session to canary April 10, 2024 11:27
@graphite-app graphite-app bot merged commit e6a5765 into canary Apr 10, 2024
32 checks passed
@graphite-app graphite-app bot deleted the darksky/copilot-plugins branch April 10, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants