Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate throttler config for new throttler version #6002

Draft
wants to merge 17 commits into
base: darksky/captcha-modular
Choose a base branch
from

Conversation

darkskygit
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Mar 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

darkskygit commented Mar 4, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @darkskygit and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 4, 2024

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.03%. Comparing base (c2b7fc1) to head (05d9b67).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           darksky/captcha-modular    #6002   +/-   ##
========================================================
  Coverage                    39.03%   39.03%           
========================================================
  Files                          356      356           
  Lines                         7262     7262           
  Branches                      1262     1262           
========================================================
  Hits                          2835     2835           
  Misses                        4209     4209           
  Partials                       218      218           
Flag Coverage Δ
unittest 39.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -58,7 +58,7 @@ export class NextAuthController {
@Throttle({
default: {
limit: 60,
ttl: 60,
ttl: 60 * 1000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am always thinking the current using of throttler for every api is so verbose.

We could have some predefined options and easily to be referenced by name.

nestjs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apis has changed a lot since last time i config the throttler, since you have mention it, i plan to reorganize the api throttle configuration except auth in this pr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously due to frequent of session request and swr's re-validation, i have significantly relax the throttlor limit, its time to adjust

@darkskygit darkskygit force-pushed the darksky/mutate-db-with-transaction branch from 256a053 to 858bf26 Compare March 5, 2024 05:18
@darkskygit darkskygit force-pushed the darksky/mutate-db-with-transaction branch from 858bf26 to df14857 Compare March 5, 2024 09:58
@darkskygit darkskygit force-pushed the darksky/migrate-throttler branch 2 times, most recently from 8344fdf to f3ac634 Compare March 5, 2024 10:01
@darkskygit darkskygit force-pushed the darksky/mutate-db-with-transaction branch from f0c3aed to 5c5208b Compare March 5, 2024 10:31
@darkskygit darkskygit force-pushed the darksky/migrate-throttler branch 2 times, most recently from 96b157e to 3f16f57 Compare March 5, 2024 10:35
@darkskygit darkskygit changed the base branch from darksky/mutate-db-with-transaction to darksky/captcha-modular March 5, 2024 10:35
This was referenced Mar 5, 2024
@darkskygit darkskygit marked this pull request as draft March 12, 2024 10:04
@darkskygit darkskygit force-pushed the darksky/captcha-modular branch 5 times, most recently from 015a230 to 637008b Compare April 24, 2024 08:22
@darkskygit darkskygit force-pushed the darksky/captcha-modular branch 2 times, most recently from 8d35fb8 to dfcb677 Compare May 15, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants