ieee802154: Remove buffers from initialize() functions
#3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These buffers should be passed to the object directly as not all users are likely to want the same buffers (and this is in fact true today).
github-actions
bot
added
nrf
Buffer should just be passed to the object when it is created, not on initialization.
bradjc
force-pushed
the
hil-radio-init-buffers
branch
from
2e54d96
to
6289b6c
Compare
ppannuto
force-pushed
the
hil-radio-init-buffers
branch
from
4face54
to
2b5b08d
Compare
jrvanwhy
previously approved these changes
May 17, 2024
ppannuto
force-pushed
the
hil-radio-init-buffers
branch
from
75fe126
to
e9785c0
Compare
ppannuto
previously approved these changes
May 17, 2024
jrvanwhy
previously approved these changes
May 17, 2024
and fix typo in comment
ppannuto
force-pushed
the
hil-radio-init-buffers
branch
from
e9785c0
to
2390dc4
Compare
ppannuto
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates the
hil::radio:Radiointerface and themacinterface to not pass buffers to capsules via theinitialize()function and instead use the conventional method of passing them in thenew()constructor.I think this is just an artifact of not knowing exactly which approach would work best at the time.
This also enables some improvements to the rf233 component and initialization in the imix board.
Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.