Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SteamOverHolland] fixes train discount bug #11169

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[SteamOverHolland] fixes train discount bug #11169

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e92f6de
[SteamOverHolland] fixes train discount bug
philcampeau Aug 22, 2024
9ecd3fd
corrects @depot.min_price to include entity as argument
philcampeau Aug 23, 2024
8f4fd53
Actual fix for train price bug
philcampeau Aug 27, 2024
3bd4c20
restores fixture, more corrections
philcampeau Aug 28, 2024
59ab8d7
Merge branch 'tobymao:master' into SOH-train-discount-fix
philcampeau Sep 16, 2024
b7f9d89
push
philcampeau Sep 16, 2024
9ead87a
Merge branch 'tobymao:master' into SOH-train-discount-fix
philcampeau Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/engine/game/g_steam_over_holland/entities.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ module Entities
type: 'train_discount',
discount: 0.1,
trains: %w[3 4 5],
when: 'buy_train',
philcampeau marked this conversation as resolved.
Show resolved Hide resolved
owner_type: 'corporation',
},
],
},
Expand Down
2 changes: 1 addition & 1 deletion lib/engine/game/g_steam_over_holland/game.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ def redeemable_shares(entity)
end

def emergency_issuable_bundles(entity)
return [] if @round.issued_shares[entity] || entity.cash >= @depot.min_depot_price
return [] if @round.issued_shares[entity] || entity.cash >= @depot.min_price(ability: nil)
philcampeau marked this conversation as resolved.
Show resolved Hide resolved

num_shares = [entity.num_player_shares, 5 - entity.num_market_shares].min

Expand Down
Loading
Loading