Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to set precision level for humanized output #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alfie-max
Copy link

not sure if this repo is still maintained..
But found this changes helpful for a customized response

Copy link

@AlexWayfer AlexWayfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks for a long time unmaintained. I personally have switched to maintained moments.

@@ -14,7 +14,7 @@ Gem::Specification.new do |gem|
gem.version = "0.7.0"
gem.license = 'MIT'

gem.add_runtime_dependency('activesupport', '~> 5.1')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks unrelated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea.. but there was no need to hard code the activesupport version here, since this wont support rails 6 now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but it's better to make unrelated changes in separate PRs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.. i'll create seaprate PR then

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#51

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think that we can close this one in favor of these two.

Copy link

@AlexWayfer AlexWayfer Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, honestly, you could change this one to something main, like precision, left it without unrelated changes, like activesupport version, and create only one separate for your case, with this activesupport version change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants