Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change activesupport load requirement to address humanize method #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

drubio1989
Copy link

@drubio1989 drubio1989 commented Oct 3, 2016

No description provided.

@drubio1989
Copy link
Author

drubio1989 commented Oct 3, 2016

Hey @tmlee, I was hoping to merge this pull request that fixes the humanize method issue. I was reading on Travis CI(https://docs.travis-ci.com/user/languages/ruby/) that the syntax for rbx-mode19 isn't supported. I also saw the following text:

'When using Rubinius, there’s currently an issue with selecting the correct version in RVM in our build environment, but only when specifying rbx as your version. As a workaround, specify rbx-2 instead.'

Is it possible that the Travis CI build could be broken which would prevent the merge of this request? I saw on the previous pull requests that the Rubinius builds passed but those were all a while ago. I love this gem and would like to incorporate it if I can with my most recent project. Thanks.

@tmlee
Copy link
Owner

tmlee commented Feb 28, 2017

Hi @drubio1989 many thanks. I have updated the master branch to pass the build.
You are right and i have ended up removing rbx from travis. I've tried with different versions of rbx based on the travis documentation and none of them work; decided to drop it.
Can you rebase from master and we can see if the build passes for this one.

What would be the consequences in your mind switching from ActiveSupport 3.2 to 4.2 in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants