Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scala-reflect with izumi-reflect #668

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdedetrich
Copy link

In progress PR of replacing scala-reflect with izumi-reflect with the intention of adding Scala 3 support to slick-pg (scala 3 doesn't support scala-reflect and that is intentional).

@mdedetrich
Copy link
Author

mdedetrich commented Oct 4, 2023

Currently blocked by zio/izumi-reflect#436

@mdedetrich
Copy link
Author

@tminglei Do you have an opinion on the linked ticket and what approach should be used?

@nafg
Copy link
Contributor

nafg commented Oct 18, 2023

@tminglei are you around?

@mdedetrich my two cents, perhaps instead of trying to mechanically convert the code, maybe we should address the root issue, is reflection really needed to achieve the objectives? Even if it's a breaking change I think it would be better to just get rid of reflection.

@hughsimpson hughsimpson mentioned this pull request Nov 28, 2023
@hughsimpson
Copy link
Contributor

hughsimpson commented Nov 29, 2023

I don't think izumi-reflect can do everything we need here. Have opened a pr to get the rest of the scala 3 support over the line in the hope that the Struct stuff can be implemented maybe with a macro or something...

@nafg
Copy link
Contributor

nafg commented Dec 4, 2023

@hughsimpson amazing

@hughsimpson
Copy link
Contributor

hughsimpson commented Dec 7, 2023

@nafg @mdedetrich Have implemented Struct support using inline in the scala 3 branch now, which I think will make this pr redundant. Was very useful starting point though 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants