Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-configure: add page #8808

Merged
merged 16 commits into from Oct 9, 2022
Merged

aws-configure: add page #8808

merged 16 commits into from Oct 9, 2022

Conversation

piraces
Copy link
Contributor

@piraces piraces commented Oct 7, 2022

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2.7.25

Related: #5653

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 7, 2022
@piraces piraces mentioned this pull request Oct 7, 2022
Open
navarroaxel
navarroaxel reviewed Oct 7, 2022
View reviewed changes
pages/common/aws-configure.md Outdated Show resolved Hide resolved
pages/common/aws-configure.md Outdated Show resolved Hide resolved
pages/common/aws-configure.md Outdated Show resolved Hide resolved
pages/common/aws-configure.md Outdated Show resolved Hide resolved
pages/common/aws-configure.md Outdated Show resolved Hide resolved
pages/common/aws-configure.md Outdated Show resolved Hide resolved
pages/common/aws-configure.md Outdated Show resolved Hide resolved
pages/common/aws-configure.md Outdated Show resolved Hide resolved
pages/common/aws-configure.md Outdated Show resolved Hide resolved
pages/common/aws-configure.md Outdated Show resolved Hide resolved
piraces and others added 14 commits October 8, 2022 11:46
@piraces @navarroaxel
Update pages/common/aws-configure.md
00e0969 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
7366486 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
064d958 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
6faab44 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
7fc00a9 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
1fdae04 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
c5fe692 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
36a19f4 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
42e18d0 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
c3e41d5 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
4691c87 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
b6a8e9c 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
19e6441 
Co-authored-by: Axel Navarro <[email protected]>
@piraces @navarroaxel
Update pages/common/aws-configure.md
277eae0 
Co-authored-by: Axel Navarro <[email protected]>
@piraces
Copy link
Contributor Author

piraces commented Oct 8, 2022

Thanks for the work correcting this PR changes. Will learn that for future contributions...

navarroaxel
navarroaxel approved these changes Oct 8, 2022
View reviewed changes
pages/common/aws-configure.md Outdated Show resolved Hide resolved
kbdharun
kbdharun approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

Wow, that's a lot of amazing reviews, Great job navarroaxel.

@kbdharun kbdharun merged commit 1077c06 into tldr-pages:main Oct 9, 2022
@piraces piraces deleted the aws-configure branch October 9, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piraces @navarroaxel @kbdharun