Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnstracer: add page #8707

Merged
merged 7 commits into from Oct 4, 2022
Merged

dnstracer: add page #8707

merged 7 commits into from Oct 4, 2022

Conversation

Faro1991
Copy link
Contributor

@Faro1991 Faro1991 commented Oct 3, 2022

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):
    1.9, ref: https://www.kali.org/tools/dnstracer/

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 3, 2022
@Faro1991
Copy link
Contributor Author

Faro1991 commented Oct 3, 2022

Related to #6863

@Faro1991 @CleanMachine1
mark parameters correctly
9be4aab 
Thanks @CleanMachine1, totally missed that one. Should obviously be in brackets.

Co-authored-by: CleanMachine1 <[email protected]>
CleanMachine1
CleanMachine1 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

reinhart1010
reinhart1010 requested changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@reinhart1010 reinhart1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Faro1991, I left some comments here for you to review.

pages/linux/dnstracer.md Outdated Show resolved Hide resolved
@Faro1991 @reinhart1010
link man page for reference
621dc78 
Co-authored-by: Reinhart Previano Koentjoro <[email protected]>
kbdharun
kbdharun approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution. I have some suggestions for this page.

Tip: We use mnemonics whenever possible for single-character flags.

pages/linux/dnstracer.md Outdated Show resolved Hide resolved
pages/linux/dnstracer.md Show resolved Hide resolved
pages/linux/dnstracer.md Outdated Show resolved Hide resolved
Faro1991 and others added 3 commits October 4, 2022 07:44
@Faro1991 @kbdharun
Mark -o in example description
4f8e292 
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@Faro1991 @kbdharun
Mark -r in example description
cdec044 
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@Faro1991 @kbdharun
Mark -o in example description
58662ad 
Accidentally put this for -s as well

Co-authored-by: K.B.Dharun Krishna <[email protected]>
kbdharun
kbdharun reviewed Oct 4, 2022
View reviewed changes
pages/linux/dnstracer.md Outdated Show resolved Hide resolved
kbdharun
kbdharun approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

Also, Welcome to tldr btw.

@kbdharun
Copy link
Member

kbdharun commented Oct 4, 2022

Hey, @Faro1991 seems like you haven't signed the CLA. Can you sign the Contributor License Agreement (CLA) at https://cla-assistant.io/tldr-pages/tldr?

@Faro1991
Copy link
Contributor Author

Faro1991 commented Oct 4, 2022

Hey, @Faro1991 seems like you haven't signed the CLA. Can you sign the Contributor License Agreement (CLA) at https://cla-assistant.io/tldr-pages/tldr?

Hey, I did on my first PR, the check just took unusually long this time. 😅

@kbdharun
Copy link
Member

kbdharun commented Oct 4, 2022 •
edited

Hey, @Faro1991 seems like you haven't signed the CLA. Can you sign the Contributor License Agreement (CLA) at https://cla-assistant.io/tldr-pages/tldr?

Hey, I did on my first PR, the check just took unusually long this time. 😅

Thanks, Now that all checks are clear. This PR is good to merge.

Yeah, recently it is taking a lot of time may be due to a heavy load this Hacktoberfest.

@reinhart1010 can you merge this PR?

reinhart1010
reinhart1010 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@reinhart1010 reinhart1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reinhart1010 reinhart1010 merged commit 2100859 into tldr-pages:main Oct 4, 2022
@Faro1991 Faro1991 deleted the dnstracer branch October 4, 2022 06:50
@kbdharun kbdharun mentioned this pull request Oct 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinhart1010 reinhart1010 reinhart1010 approved these changes

@kbdharun kbdharun kbdharun approved these changes

@CleanMachine1 CleanMachine1 CleanMachine1 approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Faro1991 @kbdharun @reinhart1010 @CleanMachine1