Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hping3: add page #7147

Merged
merged 7 commits into from Dec 2, 2021
Merged

hping3: add page #7147

merged 7 commits into from Dec 2, 2021

Conversation

ciph3rz
Copy link
Contributor

@ciph3rz ciph3rz commented Oct 23, 2021

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):

@tldr-bot

This comment has been minimized.

Sign in to view
@mfrw mfrw added the new command Issues requesting creation of a new page. label Oct 23, 2021
@mfrw mfrw changed the title initial hping3 tldr hping3: add page Oct 23, 2021
navarroaxel
navarroaxel reviewed Oct 23, 2021
View reviewed changes
pages/common/hping3.md Outdated Show resolved Hide resolved
pages/common/hping3.md Outdated Show resolved Hide resolved
pages/common/hping3.md Outdated Show resolved Hide resolved
@ciph3rz
Copy link
Contributor Author

ciph3rz commented Oct 26, 2021

#6863

sbrl
sbrl requested changes Oct 29, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

pages/common/hping3.md Outdated Show resolved Hide resolved
pages/common/hping3.md Outdated Show resolved Hide resolved
pages/common/hping3.md Outdated Show resolved Hide resolved
pages/common/hping3.md Outdated Show resolved Hide resolved
pages/common/hping3.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 30, 2021
navarroaxel
navarroaxel reviewed Oct 31, 2021
View reviewed changes
pages/common/hping3.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel requested a review from sbrl November 8, 2021 01:27
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Nov 24, 2021
sbrl
sbrl reviewed Nov 24, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my comments from above were unaddressed. Also, I've left some additional comments below. Thanks for sticking with the review process!

pages/common/hping3.md Outdated Show resolved Hide resolved
pages/common/hping3.md Outdated Show resolved Hide resolved
pages/common/hping3.md Outdated Show resolved Hide resolved
pages/common/hping3.md Outdated Show resolved Hide resolved
@navarroaxel @sbrl
Apply suggestions from code review
eeeabea 
Co-authored-by: Starbeamrainbowlabs <[email protected]>
@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Dec 1, 2021
@navarroaxel navarroaxel requested a review from sbrl December 1, 2021 10:24
sbrl
sbrl approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ciph3rz!

@sbrl sbrl merged commit 26ecfa4 into tldr-pages:main Dec 2, 2021
SethFalco added a commit to SethFalco/tldr that referenced this pull request Dec 5, 2021
@SethFalco
hping3: add page (tldr-pages#7147)
63b6a41
@fazlearefin fazlearefin mentioned this pull request Feb 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ciph3rz @tldr-bot @navarroaxel @sbrl @mfrw