Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdf-parser: add page #6961

Merged
merged 7 commits into from
Oct 13, 2021
Merged

pdf-parser: add page #6961

merged 7 commits into from
Oct 13, 2021

Conversation

gutjuri
Copy link
Member

@gutjuri gutjuri commented Oct 11, 2021

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

related to #6863

@pixelcmtd pixelcmtd added the new command Issues requesting creation of a new page. label Oct 11, 2021
navarroaxel
navarroaxel reviewed Oct 12, 2021
View reviewed changes
pages/common/pdf-parser.md Outdated Show resolved Hide resolved
pages/common/pdf-parser.md Outdated Show resolved Hide resolved
pages/common/pdf-parser.md Outdated Show resolved Hide resolved
einverne
einverne approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@einverne einverne merged commit a8d6782 into tldr-pages:main Oct 13, 2021
@gutjuri gutjuri deleted the add-pdf-parser-2 branch October 13, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@einverne einverne einverne approved these changes

@CleanMachine1 CleanMachine1 Awaiting requested review from CleanMachine1

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gutjuri @navarroaxel @einverne @pixelcmtd