Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sslstrip: add page #12681

Merged
merged 15 commits into from May 1, 2024
Merged

sslstrip: add page #12681

merged 15 commits into from May 1, 2024

Conversation

jimmychang851129
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Apr 26, 2024
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/linux/sslstrip.md:3: TLDR003 Descriptions should start with a capital letter
pages/linux/sslstrip.md:3: TLDR004 Command descriptions should end in a period
pages/linux/sslstrip.md:6: TLDR015 Example descriptions should start with a capital letter
pages/linux/sslstrip.md:18: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

pages/linux/sslstrip.md Outdated Show resolved Hide resolved
pages/linux/sslstrip.md Show resolved Hide resolved
pages/linux/sslstrip.md Outdated Show resolved Hide resolved
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

pages/linux/sslstrip.md Outdated Show resolved Hide resolved
pages/linux/sslstrip.md Outdated Show resolved Hide resolved
pages/linux/sslstrip.md Outdated Show resolved Hide resolved
pages/linux/sslstrip.md Outdated Show resolved Hide resolved
pages/linux/sslstrip.md Outdated Show resolved Hide resolved
pages/linux/sslstrip.md Outdated Show resolved Hide resolved
@vitorhcl
Copy link
Member

@kbdharun had an excellent idea and opened a PR to add an usage section in sslstrip's README.

However, I don't know when (and even if) it will be seen by the author because the last merged PR was 3 months ago.

I support using the official documentation on more info and, until @kbdharun's PR is merged, keeping a help example.

Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after my suggestions

pages/linux/sslstrip.md Outdated Show resolved Hide resolved
pages/linux/sslstrip.md Outdated Show resolved Hide resolved
pages/linux/sslstrip.md Outdated Show resolved Hide resolved
pages/linux/sslstrip.md Outdated Show resolved Hide resolved
@tldr-bot

This comment was marked as resolved.

@kbdharun kbdharun merged commit 2f1108c into tldr-pages:main May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants