arecord, convert: edit pages #12644

TheFibonacciEffect · 2024-04-14T20:59:25Z

The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
The page(s) have at most 8 examples.
The page description(s) have links to documentation or a homepage.
The page(s) follow the content guidelines.
The PR title conforms to the recommended templates.
Version of the command being documented (if known):

CLAassistant · 2024-04-14T20:59:30Z

All committers have signed the CLA.

tldr-bot · 2024-04-14T21:00:18Z

The build for this PR failed with the following error(s):

pages/common/convert.md:15: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/convert.md:16: TLDR007 Example descriptions should be surrounded by empty lines
pages/common/convert.md:0: TLDR019 Page should only include a maximum of 8 examples
pages/linux/arecord.md:
Error: Parse error on line 26:
...ord --interactive``test your microphon
---------------------^
Expecting 'TEXT', 'DASH', got 'BACKTICK'

Please fix the error(s) and push again.

tldr-bot · 2024-04-14T21:01:24Z

The build for this PR failed with the following error(s):

pages/common/convert.md:15: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/convert.md:16: TLDR007 Example descriptions should be surrounded by empty lines
pages/linux/arecord.md:
Error: Parse error on line 26:
...ord --interactive``test your microphon
---------------------^
Expecting 'TEXT', 'DASH', got 'BACKTICK'

Please fix the error(s) and push again.

tldr-bot · 2024-04-14T21:02:37Z

The build for this PR failed with the following error(s):

pages/common/convert.md:15: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/convert.md:16: TLDR007 Example descriptions should be surrounded by empty lines
pages/linux/arecord.md:26: TLDR102 Example description probably not properly annotated
pages/linux/arecord.md:27: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

tldr-bot · 2024-04-14T21:04:33Z

The build for this PR failed with the following error(s):

pages/common/convert.md:15: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/convert.md:16: TLDR007 Example descriptions should be surrounded by empty lines
pages/linux/arecord.md:26: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

tldr-bot · 2024-04-14T21:05:40Z

The build for this PR failed with the following error(s):

pages/common/convert.md:15: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/convert.md:16: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

TheFibonacciEffect · 2024-04-14T21:11:21Z

Allright now its ready : )
These commands are very useful to me and I hope they are to others as well, sorry that it took me several tries with the formatting...

pages/common/convert.md

sebastiaanspeck · 2024-04-16T01:35:00Z

pages/common/convert.md


-`convert {{path/to/image1.png path/to/image2.png ...}} +append {{path/to/output_image.png}}`
+`convert {{path/to/input_image.png}} -define jpeg:extent=512kb {{path/to/output_image.jpg}}`

 - Vertically append images:


Maybe change this example to include the horizontally append as well?

I think if we keep both horizontal and vertical append examples we will have more than 6 examples, so I chose to remove that one, because its similar to horizontal append. But we can also make some other choice.

I meant to merge the two examples into one:

convert ... -append/+append ...

Ah that makes sense, Ill add it

sebastiaanspeck · 2024-04-16T01:37:08Z

pages/linux/arecord.md

+- Test your microphone:
+
+`arecord -d 5 test-mic.wav && aplay test-mic.wav && rm test-mic.wav`


This describes a use case for arecord/aplay, I am not sure if we want this included in the tldr-page? @kbdharun @vitorhcl

Yeah, we can document only the example relevant to this page and not aplay IMO.

I kind of feel like arecord and aplay belong together but if you want to have it sepeately, thats okay too.

This describes a use case for arecord/aplay, I am not sure if we want this included in the tldr-page? @kbdharun @vitorhcl

Sorry for the delay, I didn't saw your comment. I have a different opinion than @kbdharun.

There are pages that mix some commands, so it's fine to describe a use case for both two commands, as long as one of them is the main one.

It's more about the perspective itself: this command is mainly using aplay or arecord, i.e., is the core behavior recording the microphone or playing the microphone audio? IMO it's roughly 50%, so we can keep it.

However, IMO it is important to document how to record to a file too.

I think its clear that the first command records a file.

CleanMachine1 · 2024-04-16T10:56:48Z

pages/linux/arecord.md

+- Test your microphone:
+
+`arecord -d 5 test-mic.wav && aplay test-mic.wav && rm test-mic.wav`


Suggested change

- Test your microphone:

`arecord -d 5 test-mic.wav && aplay test-mic.wav && rm test-mic.wav`

- Record 5 seconds of mic audio:

`arecord -d 5 {{path/to/output_audio.mp3}}`

Suggested change

- Test your microphone:

`arecord -d 5 test-mic.wav && aplay test-mic.wav && rm test-mic.wav`

- Record 5 seconds of mic audio:

`arecord --duration 5 {{path/to/output_audio.mp3}}`

Co-authored-by: Sebastiaan Speck <[email protected]>

TheFibonacciEffect · 2024-04-29T16:02:18Z

Is there anything that needs to be fixed before merging?

sebastiaanspeck · 2024-05-08T19:15:14Z

pages/common/convert.md

@@ -16,13 +16,13 @@

 `convert {{path/to/input_image.png}} -resize 640x480 {{path/to/output_image.png}}`

- Horizontally append images:
+- Scale an image to have a specified filesize:


Suggested change

- Scale an image to have a specified filesize:

- Scale an image to have a specified file size:

add command to resize to desired size and add command to test microphone

ec0de0e

TheFibonacciEffect requested a review from cyqsimon as a code owner April 14, 2024 20:59

github-actions bot added the page edit Changes to an existing page(s). label Apr 14, 2024

remove similar example to make space

fb18a70

formatting error

991824f

gutjuri changed the title ~~add command to resize to desired size and add command to test microphone~~ arecord, convert: edit pages Apr 14, 2024

more formatting errors, sorry

1b520f4

add collon etc

e972f2a

TheFibonacciEffect added 2 commits April 14, 2024 23:07

formatting

d9b30a9

change example order to increasing complexity

a95fdac

sebastiaanspeck reviewed Apr 16, 2024

View reviewed changes

CleanMachine1 reviewed Apr 16, 2024

View reviewed changes

TheFibonacciEffect and others added 2 commits April 16, 2024 15:17

Update pages/common/convert.md

9591c0b

Co-authored-by: Sebastiaan Speck <[email protected]>

Merge branch 'main' into main

37e0f0e

TheFibonacciEffect added 2 commits May 1, 2024 09:47

merge vertical and horzontal append

0c7ee75

better description

6bda745

sebastiaanspeck reviewed May 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

arecord, convert: edit pages #12644

arecord, convert: edit pages #12644

TheFibonacciEffect commented Apr 14, 2024 •

edited

CLAassistant commented Apr 14, 2024 •

edited

tldr-bot commented Apr 14, 2024

tldr-bot commented Apr 14, 2024

tldr-bot commented Apr 14, 2024

tldr-bot commented Apr 14, 2024

tldr-bot commented Apr 14, 2024

TheFibonacciEffect commented Apr 14, 2024 •

edited

sebastiaanspeck Apr 16, 2024

TheFibonacciEffect Apr 24, 2024

sebastiaanspeck Apr 29, 2024

TheFibonacciEffect May 1, 2024 •

edited

sebastiaanspeck Apr 16, 2024

kbdharun Apr 16, 2024

TheFibonacciEffect Apr 21, 2024

vitorhcl Apr 21, 2024

vitorhcl Apr 21, 2024

TheFibonacciEffect Apr 29, 2024

CleanMachine1 Apr 16, 2024 •

edited

sebastiaanspeck Apr 16, 2024

TheFibonacciEffect commented Apr 29, 2024

sebastiaanspeck May 8, 2024

		- Test your microphone:

		`arecord -d 5 test-mic.wav && aplay test-mic.wav && rm test-mic.wav`

	- Scale an image to have a specified filesize:
	- Scale an image to have a specified file size:

arecord, convert: edit pages #12644

Are you sure you want to change the base?

arecord, convert: edit pages #12644

Conversation

TheFibonacciEffect commented Apr 14, 2024 • edited

CLAassistant commented Apr 14, 2024 • edited

tldr-bot commented Apr 14, 2024

tldr-bot commented Apr 14, 2024

tldr-bot commented Apr 14, 2024

tldr-bot commented Apr 14, 2024

tldr-bot commented Apr 14, 2024

TheFibonacciEffect commented Apr 14, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheFibonacciEffect May 1, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CleanMachine1 Apr 16, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheFibonacciEffect commented Apr 29, 2024

Choose a reason for hiding this comment

TheFibonacciEffect commented Apr 14, 2024 •

edited

CLAassistant commented Apr 14, 2024 •

edited

TheFibonacciEffect commented Apr 14, 2024 •

edited

TheFibonacciEffect May 1, 2024 •

edited

CleanMachine1 Apr 16, 2024 •

edited