Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug with precommit check using nvs #12571

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

okineadev
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

In this patch, I added to the .husky/pre-commit file an automatic detection of the use of nvs, if the user has nvs - then the pre-commit script will use the standard version of NodeJS

If the standard version is not installed, this can be done using a simple command:

nvs link <version>

This commit closes the issue with this error - #12565

Copy link

@Teri-anric Teri-anric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey.

.husky/pre-commit Outdated Show resolved Hide resolved
.husky/pre-commit Outdated Show resolved Hide resolved
@okineadev
Copy link
Contributor Author

@fazlearefin Done!

@gutjuri
Copy link
Member

gutjuri commented Apr 2, 2024

How would this affect users of nvm that would like to run a nonstandard version of npm?

@okineadev
Copy link
Contributor Author

How would this affect users of nvm that would like to run a nonstandard version of npm?

This PR contains fixes only for nvs, I don't know anything about nvm bugs, because I don't use it.

@gutjuri
Copy link
Member

gutjuri commented Apr 2, 2024

How would this affect users of nvm that would like to run a nonstandard version of npm?

This PR contains fixes only for nvs, I don't know anything about nvm bugs, because I don't use it.

Typo :) Of course I meant to ask "How would this affect users of nvs that would like to run a nonstandard version of npm?" :)

@kbdharun kbdharun changed the title Fixed bug using nvs fix: bug with precommit check using nvs Apr 3, 2024
@okineadev
Copy link
Contributor Author

How would this affect users of nvm that would like to run a nonstandard version of npm?

This PR contains fixes only for nvs, I don't know anything about nvm bugs, because I don't use it.

Typo :) Of course I meant to ask "How would this affect users of nvs that would like to run a nonstandard version of npm?" :)

I don't even know if anyone has bugs with this - I'll look into them.

@kbdharun kbdharun requested a review from owenvoke May 9, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants