Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cal: improve util-linux page and split POSIX, osx and *BSD #12172

Merged
merged 9 commits into from Feb 14, 2024
Merged

cal: improve util-linux page and split POSIX, osx and *BSD #12172

merged 9 commits into from Feb 14, 2024

Conversation

vitorhcl
Copy link
Member

For #9612 and #11827.

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added new command Issues requesting creation of a new page. page edit Changes to an existing page(s). labels Jan 31, 2024
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/common/cal.md seems to be a copy of pages/linux/cal.md (62% matching).
  • The page pages/freebsd/cal.md already exists in the common directory.
  • The page pages/netbsd/cal.md already exists in the common directory.
  • The page pages/openbsd/cal.md already exists in the common directory.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

gutjuri
gutjuri reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added some suggestions.

pages/common/cal.md Outdated Show resolved Hide resolved
pages/common/cal.md Outdated Show resolved Hide resolved
pages/freebsd/cal.md Outdated Show resolved Hide resolved
pages/freebsd/cal.md Outdated Show resolved Hide resolved
pages/netbsd/cal.md Outdated Show resolved Hide resolved
pages/netbsd/cal.md Outdated Show resolved Hide resolved
pages/openbsd/cal.md Outdated Show resolved Hide resolved
pages/openbsd/cal.md Outdated Show resolved Hide resolved
pages/openbsd/cal.md Outdated Show resolved Hide resolved
@tldr-bot

This comment was marked as off-topic.

Sign in to view
kbdharun
kbdharun approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM after the above suggestion.

@vitorhcl @gutjuri
cal: remove incorrect note
c2c0205 
Co-authored-by: Juri Dispan <[email protected]>
@tldr-bot
Copy link

tldr-bot commented Feb 6, 2024

Hello! I've noticed something unusual when checking this PR:

  • The page pages/freebsd/cal.md already exists in the common directory.
  • The page pages/netbsd/cal.md already exists in the common directory.
  • The page pages/openbsd/cal.md already exists in the common directory.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

sebastiaanspeck
sebastiaanspeck reviewed Feb 7, 2024
View reviewed changes
pages/common/cal.md Outdated Show resolved Hide resolved
pages/freebsd/cal.md Outdated Show resolved Hide resolved
pages/linux/cal.md Outdated Show resolved Hide resolved
pages/netbsd/cal.md Outdated Show resolved Hide resolved
pages/openbsd/cal.md Outdated Show resolved Hide resolved
@vitorhcl @sebastiaanspeck
cal: use display instead of print
03f6924 
Co-authored-by: Sebastiaan Speck <[email protected]>
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/freebsd/cal.md already exists in the common directory.
  • The page pages/netbsd/cal.md already exists in the common directory.
  • The page pages/openbsd/cal.md already exists in the common directory.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/freebsd/cal.md already exists in the common directory.
  • The page pages/netbsd/cal.md already exists in the common directory.
  • The page pages/openbsd/cal.md already exists in the common directory.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/freebsd/cal.md already exists in the common directory.
  • The page pages/netbsd/cal.md already exists in the common directory.
  • The page pages/openbsd/cal.md already exists in the common directory.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/freebsd/cal.md already exists in the common directory.
  • The page pages/netbsd/cal.md already exists in the common directory.
  • The page pages/openbsd/cal.md already exists in the common directory.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/freebsd/cal.md already exists in the common directory.
  • The page pages/netbsd/cal.md already exists in the common directory.
  • The page pages/openbsd/cal.md already exists in the common directory.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/freebsd/cal.md already exists in the common directory.
  • The page pages/netbsd/cal.md already exists in the common directory.
  • The page pages/openbsd/cal.md already exists in the common directory.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@vitorhcl vitorhcl mentioned this pull request Feb 12, 2024
Open
@sebastiaanspeck sebastiaanspeck merged commit 832eed8 into tldr-pages:main Feb 14, 2024
4 checks passed
sebastiaanspeck added a commit to sebastiaanspeck/tldr that referenced this pull request Feb 15, 2024
@vitorhcl @gutjuri @sebastiaanspeck
cal: improve util-linux page and split POSIX, osx and *BSD (tldr-page…
4039447 
…s#12172)

Co-authored-by: Juri Dispan <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
@vitorhcl vitorhcl deleted the cal-split-util-linux-and-posix branch February 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutjuri gutjuri gutjuri left review comments

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

@kbdharun kbdharun Awaiting requested review from kbdharun

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page. page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vitorhcl @tldr-bot @sebastiaanspeck @gutjuri @kbdharun