Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more: split util-linux and POSIX implementations #12171

Merged
merged 3 commits into from Feb 13, 2024

Conversation

vitorhcl
Copy link
Member

For #9612 and #11827.

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

I don't think BSD platforms and osx need a platform-specific page, as there are many examples already.

Unfortunately, util-linux options are quite incompatible with POSIX, as well as some options on NetBSD and FreeBSD (and thus macOS), given that less and more share the same code on them. OpenBSD, as expected, fully follows POSIX, with the exception of the skip forward functionality, which is not currently implemented.

@github-actions github-actions bot added new command Issues requesting creation of a new page. page edit Changes to an existing page(s). labels Jan 31, 2024
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages/linux/more.md seems to be a copy of pages/common/more.md (78% matching).

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have some suggestions.

pages/common/more.md Outdated Show resolved Hide resolved
pages/linux/more.md Outdated Show resolved Hide resolved
pages/linux/more.md Outdated Show resolved Hide resolved
pages/common/more.md Outdated Show resolved Hide resolved
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

LGTM, after @gutjuri's suggestions.

@vitorhcl vitorhcl requested a review from gutjuri February 9, 2024 01:25
@tldr-bot

This comment was marked as outdated.

1 similar comment
@tldr-bot

This comment was marked as off-topic.

@kbdharun kbdharun merged commit 2624ea6 into tldr-pages:main Feb 13, 2024
4 checks passed
@vitorhcl vitorhcl deleted the more-split-util-linux-and-posix branch February 13, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page. page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants