Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umount: split common and util-linux implementations #12045

Merged
merged 2 commits into from Jan 10, 2024

Conversation

vitorhcl
Copy link
Member

@vitorhcl vitorhcl commented Jan 8, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

It isn't a POSIX command, it first appeared on Version 1 AT&T UNIX and has some common options accross the implementation. I've used OpenBSD docs in common because it has less options and they are supported by FreeBSD, NetBSD and macOS.

For #11827.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Jan 8, 2024
@tldr-bot
Copy link

tldr-bot commented Jan 8, 2024

Hello! I've noticed something unusual when checking this PR:

  • The page pages/linux/umount.md seems to be a copy of pages/common/umount.md (69% matching).

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot

This comment was marked as resolved.

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Jan 8, 2024
@tldr-bot

This comment was marked as duplicate.

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@cyqsimon cyqsimon merged commit 5ecd1ac into tldr-pages:main Jan 10, 2024
4 checks passed
@sebastiaanspeck sebastiaanspeck mentioned this pull request Jan 10, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page. page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants