Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill: split POSIX and util-linux implementations #12044

Merged
merged 1 commit into from Jan 9, 2024
Merged

kill: split POSIX and util-linux implementations #12044

merged 1 commit into from Jan 9, 2024

Conversation

vitorhcl
Copy link
Member

@vitorhcl vitorhcl commented Jan 8, 2024 •
edited

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

*BSD and macOS don't have any extensions to POSIX, so I didn't create a page for each one of them.

For #11827 and #9612.

@github-actions github-actions bot added new command Issues requesting creation of a new page. page edit Changes to an existing page(s). labels Jan 8, 2024
@tldr-bot
Copy link

tldr-bot commented Jan 8, 2024

Hello! I've noticed something unusual when checking this PR:

  • The page pages/linux/kill.md seems to be a copy of pages/common/kill.md (90% matching).

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@vitorhcl vitorhcl mentioned this pull request Jan 9, 2024
Open
kbdharun
kbdharun approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit 8c478fc into tldr-pages:main Jan 9, 2024
4 checks passed
@vitorhcl vitorhcl deleted the kill-posix-util-linux branch January 9, 2024 15:05
@sebastiaanspeck sebastiaanspeck mentioned this pull request Jan 10, 2024
Merged
5 tasks
@vitorhcl vitorhcl mentioned this pull request Jan 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@kbdharun kbdharun kbdharun approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page. page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vitorhcl @tldr-bot @sebastiaanspeck @kbdharun