Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tldr.py: fix search #244

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tldr.py: fix search #244

wants to merge 2 commits into from

Conversation

CleanMachine1
Copy link
Member

closes #231

This is a really lazy fix for the issue, mainly since I am not 100% sure about all of the code.

Would appreciate some feedback.

@kbdharun kbdharun requested a review from vitorhcl May 9, 2024 13:24
kbdharun
kbdharun approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the changes. Tested it locally and this works much better than the previous broken approach.

@vitorhcl
Copy link
Member

I'll see if I can maybe review the code next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@vitorhcl vitorhcl Awaiting requested review from vitorhcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tldr --search "KEYWORDS" does not work
3 participants
@CleanMachine1 @vitorhcl @kbdharun