Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove events from pickle cache #37

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Remove events from pickle cache #37

merged 1 commit into from
Dec 7, 2023

Conversation

tkdrob
Copy link
Owner

@tkdrob tkdrob commented Dec 7, 2023

Proposed change

Events were being saved to the pickle cache. This resulted in queries to S3 with expired credentials when there is no recordings available to get from AWS to replace the "current" event. Events are no longer saved to the pickle cache and are instead stored in memory.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • The code has been formatted (make lint)
  • Tests have been added to verify that the new code works.

@tkdrob tkdrob merged commit 89a555a into master Dec 7, 2023
6 checks passed
@tkdrob tkdrob deleted the events_cache branch December 7, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant