Added unFocusTextArea to manage text area blur functionality #286
+32
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baiamansama
force-pushed
the
feature/unfocus-text-area
branch
from
b5a3bcc to
3e7d639
Compare
tjtanjin
requested changes
Dec 17, 2024
Comment on lines
+162
to
+165
| const callRcbEventMock = jest.fn(); | ||
| mockUseRcbEventInternal.mockReturnValue({ | ||
| callRcbEvent: callRcbEventMock, | ||
| }); |
There was a problem hiding this comment.
This is actually unused, the text area currently only emits an event for text change. That said, it might be a good idea to emit events for focusing/blurring the text area in future (topic for another time).
| @@ -105,7 +105,16 @@ export const useTextAreaInternal = () => { | |||
| }, [textAreaDisabled]); | |||
|
|
|||
| /** | |||
| * Retrieves text area value. | |||
| * Focuses on text area. | |||
There was a problem hiding this comment.
This comment needs to be updated as well.
| * Retrieves text area value. | ||
| * Focuses on text area. | ||
| */ | ||
| const unFocusTextArea = useCallback(() => { |
There was a problem hiding this comment.
Instead of unFocusTextArea, let's go with blurTextArea which will be better inline with the DOM APIs (do rename the relevent parts accordingly).
There was a problem hiding this comment.
applied changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
unFocusTextAreafunctionality in theuseTextAreaInternalhook, which allows programmatic removal of focus from the text area. This complements the existingfocusTextAreamethod and provides additional control over the text area's behavior.Closes #(issue)
What change does this PR introduce?
Please select the relevant option(s).
NA
What is the proposed approach?
The unFocusTextArea method was added as a useCallback function within the useTextAreaInternal hook. It leverages the blur method on the inputRef to remove focus from the text area. Additionally, a new test case was created to verify this behavior, ensuring it works as intended without impacting existing functionality.
Checklist: