Fix for "TypeError: write() argument must be str, not bytes" on Python 3.8+ #31
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n 3.8 As the output file is created for writing text and lxml raw generates bytes objects an error is thrown. Opening the file in binary mode solves the issue.
|
cool! LGTM |
|
Just confirmed this patch as a solution for the bug. |
utopiabound
approved these changes
Jan 24, 2022
|
+1 for merging this @tjfontaine |
Ljzd-PRO
approved these changes
Jul 10, 2022
|
Can confirm it as an solution for Python 3.6.8 |
cookieBerlin
approved these changes
Jan 17, 2023
|
@tjfontaine @superna9999 @rchenzheng any chance you could merge this, please? |
Unfortunately I do not have write access. |
|
works for me, please merge to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the output file is created for writing text and lxml raw generates bytes objects an error is thrown.
Opening the file in binary mode solves the issue.