-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add push notifications #1704
base: dev
Are you sure you want to change the base?
Conversation
986c2f5
to
19100ed
Compare
This is great!!! Are you all done or still working on stuff? great work!! |
Everything is done, I'll try adding that feature 👍 |
51736f7
to
27ee277
Compare
73f2fd1
to
fa19346
Compare
cc9af14
to
6129d74
Compare
7df9991
to
f212a96
Compare
f219e26
to
9ca0850
Compare
|
848cc66
to
c134c08
Compare
@alanzhu0 everythings done 👍 |
Idk why it's failing I ran build_docs like 20 times |
to test:
|
7d829ab
to
d655102
Compare
d655102
to
f1b0bf8
Compare
4909092
to
852be7e
Compare
Proposed changes
Brief description of rationale
Many of Ion's current notification features rely on sending emails but people check push notifications more often. This makes the PWA experience more intuitive especially on mobile
Notes
create_vapid_keys.py
) should be generated once and never changed, otherwise all push subscriptions will be invalidated and users will have to manually subscribe to push notifications againVideo of it working on windows
Video of it working on iOS