chore: update typehints via __future__.annotations
#1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGrace2282
force-pushed
the
typehints
branch
2 times, most recently
from
a23b725 to
8129a14
Compare
JasonGrace2282
force-pushed
the
typehints
branch
3 times, most recently
from
4df3b23 to
5f11e4c
Compare
|
@NotFish232 review |
NotFish232
requested changes
Jun 18, 2024
JasonGrace2282
force-pushed
the
typehints
branch
from
5f11e4c to
2bf69c6
Compare
JasonGrace2282
force-pushed
the
typehints
branch
3 times, most recently
from
5dbe308 to
9fbea82
Compare
JasonGrace2282
force-pushed
the
typehints
branch
6 times, most recently
from
896336d to
3f8c994
Compare
This commit changes all typehints from "old" ways of typehinting (type comments, `Union`, etc.) to more modern ways, like using | notation for unions, etc.
JasonGrace2282
force-pushed
the
typehints
branch
from
3f8c994 to
5e627d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay one less annoying thing when at some point dependencies are bumped