-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC: Raise privilege if executing in ROM #258
Draft
dehanj
wants to merge
7
commits into
pc_based_access_control_spi_2
Choose a base branch
from
pc_based_access_control_spi_2_sycalls_fur_alle
base: pc_based_access_control_spi_2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PoC: Raise privilege if executing in ROM #258
dehanj
wants to merge
7
commits into
pc_based_access_control_spi_2
from
pc_based_access_control_spi_2_sycalls_fur_alle
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehanj
commented
Aug 29, 2024
Comment on lines
+500
to
+501
fw_app_mode_new = 1'h1; | ||
fw_app_mode_new = 1'h1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fw_app_mode_new
set twice.
dehanj
force-pushed
the
pc_based_access_control_spi_2
branch
from
November 15, 2024 13:13
f5f57ff
to
90c94ce
Compare
Access logic looks at instruction execution from a defined trampoline address to enable stateful SPI access. The access is disabled as soon as an instruction is executed from any address in RAM. Signed-off-by: Joachim Strömbergson <[email protected]>
Add testcase that checks that access control is enabled and disabled as expected. Signed-off-by: Joachim Strömbergson <[email protected]>
Signed-off-by: Joachim Strömbergson <[email protected]>
Signed-off-by: Joachim Strömbergson <[email protected]>
1. Debug tk1 core with initial changes to fw-app-mode. 2. Debug testbench with fixes related to name changes for address and data RAM randomization. 3. Debug test6 that checks SPI access. Signed-off-by: Joachim Strömbergson <[email protected]>
FW mode must now be explicitlty enabled. App mode will be automatically enabled when jumping to the start of the loaded application. Signed-off-by: Joachim Strömbergson <[email protected]>
Signed-off-by: Joachim Strömbergson <[email protected]>
dehanj
force-pushed
the
pc_based_access_control_spi_2_sycalls_fur_alle
branch
from
November 15, 2024 13:16
df10908
to
fd357a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PoC of a generic syscall and how a lock could look like.
Fixes # (issues)
Type of change
Please tick any that are relevant to this PR and remove any that aren't.
Submission checklist