-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies to support Illuminate v11 components #702
Conversation
@bakerkretzmar Would love to get your eyes on this, and hear your thoughts about the |
Hey @damiani I have installed a test blog locally I did get a collections error:
and there is one test failing locally
I ran |
With regard to the ci suite the composer was bumped to 8.2 for being able to add Otherwise we could relax this to 8.1 and merge it and then tag a v2 with 8.2 as the minimum version to which we can add new features like prompts. Happy to help in this process any way I can. Cheers, |
@damiani this looks good to me! I think the fact that overriding that method was never documented does make this less of a concern re: backwards compatibility. We might as well drop PHP 8.0 and 8.1 from the test suite here too, and that change I think is fine to release without a major version bump. |
@njames What is the test you have failing locally? Your output shows a deprecation notice. |
Thanks @damiani https://github.com/njames/jigtest was created from my local version of jigsaw and I used |
This is more detail from the failed test running locally - ( I am running PHP 8.3.3 from herd on an intel MBP in this instance )
|
Odd, that test passes for me locally and in CI. So I'm thinking we ignore that local failure of yours for now :) |
Interestingly on my Linux machine PHP 8.3.4 / valet all the tests pass |
Aha, same here ... it fails on 8.3.3, passes on 8.3.4. I'll look at this a little closer ... this particular test is for a pretty obscure edge-case, but I'm curious what changed between versions. |
The test failure on 8.3.3 is for an obscure escaped verson of |
This PR upgrades the following key dependencies:
In the process, this required upgrades two Markdown-related dependencies:
The
front-yaml
upgrade adds astring
return type declaration to theparse
method; since modifying Jigsaw's markdown parser isn't documented (other than using thecommonmark
alternative as mentioned in #687, which should be unaffected), I don't think we need to consider this a breaking change.(This PR builds on #701, from @njames, focusing solely on bumping underlying dependencies to Illuminate v11 components, without the CS fixes and the addition of Laravel Prompts. It supersedes #677.)