Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xgboost changes for case weights #696

Merged
merged 3 commits into from
Apr 7, 2022
Merged

xgboost changes for case weights #696

merged 3 commits into from
Apr 7, 2022

Conversation

topepo
Copy link
Member

@topepo topepo commented Apr 4, 2022

@topepo topepo changed the title changes for case weights xgboost changes for case weights Apr 4, 2022
@topepo
Copy link
Member Author

topepo commented Apr 4, 2022

Tests are in 99d1bc3

@topepo topepo requested review from hfrick and DavisVaughan April 4, 2022 22:20
@topepo topepo mentioned this pull request Apr 4, 2022
Open
DavisVaughan
DavisVaughan approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

R/boost_tree.R Show resolved Hide resolved
hfrick
hfrick approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

We will probably need to pass the objective from xgb_train() to as_xgb_data() because the labels required differ between survival:cox and survival:aft but we'll figure that out in censored and then open another PR

@topepo topepo merged commit 1288124 into main Apr 7, 2022
@topepo topepo deleted the xgb-train-mods branch April 7, 2022 23:41
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DavisVaughan DavisVaughan DavisVaughan approved these changes

@hfrick hfrick hfrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@topepo @hfrick @DavisVaughan