use hardhat::quantile_pred #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💢 |
hfrick
approved these changes
Oct 16, 2024
Comment on lines
+50
to
+51
| possible_cols <- c(".pred_quantile", ".pred_lower", ".pred_upper") | ||
| existing_cols <- intersect(possible_cols, nms) |
| } | ||
|
|
||
| re_nest <- function(df) { | ||
| .row <- 1:nrow(df) |
There was a problem hiding this comment.
Suggested change
| .row <- 1:nrow(df) | |
| .row <- seq_len(nrow(df)) |
Comment on lines
-243
to
-246
| expect_equal( | ||
| tidyr::unnest(pred, cols = .pred)$.pred_quantile, | ||
| do.call(rbind, exp_pred)$est | ||
| ) |
There was a problem hiding this comment.
Can we keep the check on the values here, like we did for the flexsurv engine? I don't mind if the checks on the confidence intervals below only check the structure.
| # column with co.lumns ".quantile" and ".pred_quantile" and perhaps | ||
| # ".pred_lower" and ".pred_upper" | ||
|
|
||
| flexsurv_to_quantile_pred <- function(x, object) { |
There was a problem hiding this comment.
There is already another function to use in the post hook of the prediction module, called flexsurv_post(). Can we call this one flexsurv_post_quantile()?
| df | ||
| } | ||
|
|
||
| nested_df_iter <- function(df, col) { |
There was a problem hiding this comment.
How about col_to_quantile_pred() as a name?
topepo
commented
Oct 17, 2024
| @@ -57,7 +57,7 @@ jobs: | |||
| extra-packages: | |||
| any::rcmdcheck, | |||
| aorsf=?ignore-before-r=4.2.0, | |||
| pec=?ignore-before-r=4.3.0 | |||
| pec=?ignore-before-r=4.4.0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for tidymodels/parsnip#1203 to convert quantile predictions to the new vctrs class.