ctaltracker: Add selectable destination and timing offset options #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a selectable destination enables you to target the trains you would like to see given a route you want to travel. Personally, I wanted to see the trains available for my commute to work. Adding a timing offset enables you to see trains you could catch given you live X minutes away from the your departure station
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Specifically the following: - Removed app_code usage from CTA_STATIONS_URL - Added comments to indicate sections - Organized function definitions with explicit hoisting - Move render logic out of CTA Arrivals fetch function
matslina
reviewed
Nov 5, 2024
|
@samshapiro13 Thoughts? |
Co-authored-by: Mats Linander <[email protected]>
|
Messaging @samshapiro13. Your car is illegally parked. Psych, but while you're here do you have any thoughts? |
|
These additions sound good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
I tested this using
pixlet serve, disabled some caching and my own CTA Arrivals API token. Everything worked on my machine... and I believe it will work on yours. I tested each commit individually incase the refactor was not preferable.I developed this independently but pivoted to this contribution. I wanted the Tidbyt to help with my commute to work. I live a 7 minute walk from the train station, so knowing the next two trains are arriving now and in 2 minutes does not help.
I am happy to independently publish an app if that would be easier or preferable (but there are already three-ish :P)
*I was able to hit
https://data.cityofchicago.org/resource/8pix-ypme.jsonwithout anapp_tokenso I removed it. It might be required but I was unsure how to locate whether it is required.