Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(indexticker): more indicie and null indicator values support #2836

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wayne-shih
Copy link
Contributor

What's changed?

Preview

CleanShot.2024-10-29.at.10.06.54.mp4

@tidbyt
Copy link

tidbyt bot commented Oct 29, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of animation.star requires review
🟡 Original Author The original author (M0ntyP) does not match the PR author (wayne-shih)

@wayne-shih wayne-shih changed the title feat(indexticker): more indicie and null indicator values support fix(indexticker): more indicie and null indicator values support Oct 29, 2024
@matslina
Copy link
Contributor

@M0ntyP PTAL?

@M0ntyP
Copy link
Contributor

M0ntyP commented Nov 8, 2024

Hey @matslina & @wayne-shih , sorry for the delay!

Not sure what PTAL means, but if you're looking for my approval to add these changes then go right ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants