Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version pin in devcontainer #2833

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RobRoseKnows
Copy link

The version pin in the devcontainer means that pixlet create and pixlet check are unavailable. I removed the pinned version so that by default we install the latest pixlet.

@tidbyt
Copy link

tidbyt bot commented Oct 27, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
🟡 App Dir File '.devcontainer/install_pixlet.sh' is not below apps/
Modules No .star files modified
🟡 Original Author The original author (joshspicer) does not match the PR author (RobRoseKnows)

@tidbyt-bot
Copy link

tidbyt-bot commented Oct 27, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@RobRoseKnows
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants