fixup! Try without error wrapping to see if error message is clearer

tibdex · Sep 9, 2023 · c2dc007 · c2dc007
1 parent 4369b4b
commit c2dc007
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/src/fetch-installation-token.ts b/src/fetch-installation-token.ts
@@ -1,3 +1,4 @@
+import { debug } from "@actions/core";
 import { getOctokit } from "@actions/github";
 import { createAppAuth } from "@octokit/auth-app";
 import { request } from "@octokit/request";
@@ -67,6 +68,8 @@ export const fetchInstallationToken = async ({
     throw new Error("Could not get retrieve installation.", { cause: error });
   }
 
+  debug(`Retrieved installation ID: ${installationId}.`);
+
   try {
     const {
       data: { token },

diff --git a/src/index.ts b/src/index.ts
@@ -1,7 +1,13 @@
 import { Buffer } from "node:buffer";
 
-import { getInput, info, setFailed, setOutput, setSecret } from "@actions/core";
-import ensureError from "ensure-error";
+import {
+  debug,
+  getInput,
+  info,
+  setFailed,
+  setOutput,
+  setSecret,
+} from "@actions/core";
 import isBase64 from "is-base64";
 
 import { fetchInstallationToken } from "./fetch-installation-token.js";
@@ -24,11 +30,13 @@ try {
     mode: installationRetrievalMode,
     payload: installationRetrievalPayload,
   });
+  debug(`Installation retrieval details: ${installationRetrievalDetails}.`);
 
   const permissionsInput = getInput("permissions");
   const permissions = permissionsInput
     ? (JSON.parse(permissionsInput) as Record<string, string>)
     : undefined;
+  debug(`Requested permissions: ${permissions}.`);
 
   const privateKeyInput = getInput("private_key", { required: true });
   const privateKey = isBase64(privateKeyInput)
@@ -39,6 +47,7 @@ try {
   const repositories = repositoriesInput
     ? (JSON.parse(repositoriesInput) as string[])
     : undefined;
+  debug(`Requested repositories: ${permissions}.`);
 
   const token = await fetchInstallationToken({
     appId,
@@ -52,8 +61,8 @@ try {
   setSecret(token);
   setOutput("token", token);
   info("Token generated successfully!");
-} catch (_error: unknown) {
-  const error = ensureError(_error);
-  console.error(error);
+} catch (error) {
+  // Using `console.error()` instead of only passing `error` to `setFailed()` for better error reporting.
+  console.debug(error);
   setFailed("");
 }
diff --git a/src/installation-retrieval-details.ts b/src/installation-retrieval-details.ts
@@ -14,7 +14,7 @@ export const getInstallationRetrievalDetails = ({
 }>): InstallationRetrievalDetails => {
   switch (mode) {
     case "id":
-      return { mode, id: Number(payload) };
+      return { mode, id: parseInt(payload) };
     case "organization":
       return { mode, org: payload };
     case "repository":