-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pipeline filenames #8637
base: master
Are you sure you want to change the base?
Conversation
⚠ WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future. Non-collaborators requested: Attn Admins: Admin Instructions:
|
Details about a particular pipeline change over time - such as the specific Linux distro or toolchain version. At the same time, the pipeline files are directly referenced in Azure Pipelines to run the pipeline and few users have access to change those details. To make the files less likely to refer to outdated information over time and reduce the need for an Azure Pipeline administrator to get involved, the files are updated to drop specific details apart from the host OS environment used in the pipeline. Signed-off-by: Michael Kubacki <[email protected]>
Details about a particular pipeline change over time - such as the specific Linux distro or toolchain version. At the same time, the pipeline files are directly referenced in Azure Pipelines to run the pipeline and few users have access to change those details. To make the files less likely to refer to outdated information over time and reduce the need for an Azure Pipeline administrator to get involved, the files are updated to drop specific details apart from the host OS environment used in the pipeline. Signed-off-by: Michael Kubacki <[email protected]>
Details about a particular pipeline change over time - such as the specific Linux distro or toolchain version. At the same time, the pipeline files are directly referenced in Azure Pipelines to run the pipeline and few users have access to change those details. To make the files less likely to refer to outdated information over time and reduce the need for an Azure Pipeline administrator to get involved, the files are updated to drop specific details apart from the host OS environment used in the pipeline. Signed-off-by: Michael Kubacki <[email protected]>
Updates the readme file for the current naming convention used for pipeline files. Signed-off-by: Michael Kubacki <[email protected]>
07fde3d
to
d59466a
Compare
@mdkinney, I can do the work needed in Azure Pipelines, but do you have a preference?
(2) is more work but can make the transition cleaner by keeping the previously named status checks associated with the pipelines as they were when those checks were run. In either case, the pipelines moving forward will use new (more accurate) names that will be reflected in the GitHub status checks. |
If we want to add CLANG support to Windows and Linux builds, would that be added in these file. The tool chain name was removed. Should we keep the tool chain family in the file names? |
Changing the names of the status checks presented by Azure Pipelines will require a lot of coordination because those check names have to be configured in the GitHub branch protection rules. |
Technically, the Clang and non-Clang toolchain could run in parallel and have their individual jobs reported (like they are today from those generated in the matrix). However, I was already considering including the toolchain name (i.e. |
Right now, the required status checks are tied to the toolchain: As part of this transition, at a minimum, the pipeline names will change (either in the existing pipelines or in newly added pipelines). Once they are agnostic tool specific toolchains, they, like the filenames, won't be as brittle to change in the future. |
Description
Details about a particular pipeline change over time - such as the specific Linux distro or toolchain version. At the same time, the pipeline files are directly referenced in Azure Pipelines to run the pipeline and few users have access to change those details.
To make the files less likely to refer to outdated information over time and reduce the need for an Azure Pipeline administrator to get involved, the files are updated to drop specific details apart from the host OS environment used in the pipeline.
How This Was Tested
Azure pipelines
Integration Instructions