Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkPkg/UefiPxeBcDxe: Bugfix for pxe driver #10572

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

luobing
Copy link

@luobing luobing commented Dec 28, 2024

Ensure the poniter is not null before free it

Description

During stress testing of PXE boot, the following message occasionally appeared:

ASSERT_EFI_ERROR (Status = Invalid Parameter)  
ASSERT [UefiPxeBcDxe] /home/Bill.Li/code/build-platform/corsica/uefi/edk2/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c(813): !EFI_ERROR (Status)

After debugging, I found that the pointer Ip4nic->DevicePath was null when being freed.

How This Was Tested

Perform PXE boot testing using Qemu and VirtioNet NIC.

Integration Instructions

N/A

@mdkinney
Copy link
Member

Please rebase this PR to latest version of edk2. This PR is showing changes from submodules that are not related

@luobing
Copy link
Author

luobing commented Dec 29, 2024

Please rebase this PR to latest version of edk2. This PR is showing changes from submodules that are not related
OK, It's my fault for not noticing the submodule changes.

@luobing luobing reopened this Dec 29, 2024
Ensure the poniter is not null before free it

Signed-off-by: Bing Luo <[email protected]>
@mdkinney mdkinney added the push Auto push patch series in PR if all checks pass label Dec 31, 2024
@mergify mergify bot merged commit 070eadb into tianocore:master Dec 31, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants