UefiPayloadPkg: Minor fixes #10571
Open
UefiPayloadPkg: Minor fixes #10571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to version 1.7.2 which has setprop_bool(). Take from https://github.com/dgibson/dtc.git commit: 18f4f30 ("build: fix -Dtools=false build") Signed-off-by: Simon Glass <[email protected]>
At present Tianocore is started as a 32-bit image, even on 64-bit machines. So for now, set the architecture accordingly. Note that FIT uses "i386" rather than "x86" Signed-off-by: Simon Glass <[email protected]>
When developing this script it is helpful to get a full traceback when something goes wrong. Raise an exception to ensure this. Signed-off-by: Simon Glass <[email protected]>
tianocore-assign-reviewers
bot
requested review from
benjamindoron,
Benny3345678,
ChaselChiu,
gdong1,
gguo11837463,
jameslu8,
leiflindholm,
lgao4,
LinusvPelt,
LiuZhiguang001,
mdkinney and
Sean-StarLabs
| @@ -130,10 +130,10 @@ def BuildUniversalPayload(Args): | |||
| BuildDir = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/UefiPayloadPkg{}").format (Args.Arch)) | |||
| if Args.Arch == 'X64': | |||
| BuildArch = "X64" | |||
| FitArch = "x86_64" | |||
| FitArch = "i386" | |||
There was a problem hiding this comment.
As I said on the other change, this shouldn't be here. coreboot will call payloads in 32-bit mode no matter what, so coreboot will always pass -a IA32 to the script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here are a few fixes for Universal Payload (UPL) which are applicable to master, to help it work with U-Boot
These are brought in from my main PR[1], as that is still dependent on Benjamin Doron's work and cannot be reviewed yet.
How This Was Tested
Using U-Boot branch 'upl' at sjg.u-boot.org
./scripts/build-qemu.sh -a x86 -w -u ~dev/edk2/Build/UefiPayloadPkgIA32/UniversalPayload.fit -rs
Integration Instructions
N/A
[1] #10570