Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoPkg: Add sleep() function to BaseCryptLibMbedTls #10569

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HemaAnmisha
Copy link

In BaseCryptLib sleep() function is defined,
apply the same sleep function to BaseCryptLibMbedTls

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

@liyi77
Copy link
Contributor

liyi77 commented Jan 2, 2025

Hi, What problem does this patch fix? Any error will occur in MbedTls without the sleep() function?

@HemaAnmisha
Copy link
Author

Hi, What problem does this patch fix? Any error will occur in MbedTls without the sleep() function?

Hi, it fixes the below undefined issue
OpensslLib.lib(sleep.obj) : error LNK2001: unresolved external symbol sleep Tpl.c

@liyi77
Copy link
Contributor

liyi77 commented Jan 2, 2025

Hi, What problem does this patch fix? Any error will occur in MbedTls without the sleep() function?

Hi, it fixes the below undefined issue OpensslLib.lib(sleep.obj) : error LNK2001: unresolved external symbol sleep Tpl.c

LGTM, I will merge it after CI error fixed.

@HemaAnmisha HemaAnmisha force-pushed the crypt_fixsleep branch 4 times, most recently from 848fa0e to 6053537 Compare January 2, 2025 10:35
In BaseCryptLib sleep() function is defined,
apply the same sleep function to BaseCryptLibMbedTls

Signed-off-by: "Kalavakolanu, Hema Anmisha" <[email protected]>
@liyi77 liyi77 added the push Auto push patch series in PR if all checks pass label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants