Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routing.py to handle circular references #11425

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
1 change: 1 addition & 0 deletions fastapi/routing.py
Original file line number Diff line number Diff line change
Expand Up @@ -1204,6 +1204,7 @@ def read_users():
app.include_router(internal_router)
```
"""
assert self is not router, "Router cannot be the same as parent"
if prefix:
assert prefix.startswith("/"), "A path prefix must start with '/'"
assert not prefix.endswith(
Expand Down
11 changes: 11 additions & 0 deletions tests/test_router_circular_import.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import pytest
from fastapi import APIRouter, FastAPI


def test_router_circular_import():
app = FastAPI()
router = APIRouter()

app.include_router(router)
with pytest.raises(AssertionError, match="Router cannot be the same as parent"):
router.include_router(router)