Fix toolbar height in account settings #7860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the toolbar to grow when using a large system font size.
cketti
commented
May 21, 2024
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <resources> | |||
| <dimen name="toolbarTitleMarginVertical">8dp</dimen> | |||
There was a problem hiding this comment.
The Material 3 spec doesn't seem to explicitly specify this for the small top app bar. However, the app bar height is given as 64dp and the icon size as 48dp x 48dp. That leaves 16dp. Using an equal size for top and bottom padding we arrive at 8dp.
There was a problem hiding this comment.
It is vertically centered and title and subtitle are not officially supported in the Material 3 spec. We need to check with design if we still want to support this. Could be part of the settings rewrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap_contentfor the toolbar height, so increasing the system font size doesn't break the layout.androidx.appcompat.widget.ToolbartoMaterialToolbar.Related to #7854