Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onBackPressed() usage [1/x] #7859

Merged
merged 5 commits into from
May 27, 2024
Merged

Remove onBackPressed() usage [1/x] #7859

merged 5 commits into from
May 27, 2024

Conversation

cketti
Copy link
Member

@cketti cketti commented May 21, 2024

A first step in removing custom onBackPressed() implementations and calls to this method.

See #6476

@cketti cketti requested a review from wmontwe as a code owner May 21, 2024 11:12
Copy link
Collaborator

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I just wondered about this and the following pull-requests that there are super tiny commits that logically could be in one step, especially as there was previously a demand to keep the commit count low because of git history.

@cketti
Copy link
Member Author

cketti commented May 22, 2024

While there's the common goal of removing usages of onBackPressed(), each commit uses a slightly different approach (hopefully) appropriate for the context. Separating the changes makes it easier to change the approach in a particular case should the reviewer suggest a better alternative. I think it also makes it easier to review the code.

In general I think having granular commits is a good thing. What I think we can and should avoid is having unnecessary fixup commits. Fixup commits are nice during code reviews, but should be squashed before a PR branch is merged. Fixup commits are unnecessary noise once the review is done.

@cketti cketti merged commit e1ac98f into main May 27, 2024
2 checks passed
@cketti cketti deleted the onBackPressed_1 branch May 27, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants