Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Taskfile support #28

Closed
wants to merge 5 commits into from
Closed

[WIP] Taskfile support #28

wants to merge 5 commits into from

Commits on May 7, 2023

  1. modify watch.sh to be compatible with Task 

    it accepts an optional `task` argument which makes it run task commands instead of make commands (the default if no argument is supplied).

since I'm on Windows I had to add a parameter to .gitattributes so I could save watch.sh with LF line endings, otherwise it would fail to be executed in Linux.
    @HeCorr
    HeCorr committed May 7, 2023
    Configuration menu
    Copy the full SHA
    ad98657 View commit details
    Browse the repository at this point in the history

  2. update BINARY_NAME comment on Makefile 

    `BINARY_NAME` is also utilized as the Docker image name (line 26), so update the comment to reflect that.
    @HeCorr
    HeCorr committed May 7, 2023
    Configuration menu
    Copy the full SHA
    2951cb0 View commit details
    Browse the repository at this point in the history

  3. create Taskfile.yml, replicating Makefile commands 

    note: `task watch` doesn't currently work on Windows due to the dependency on `watch.sh`. the other tasks should work just fine, however I have not tested that.
    @HeCorr
    HeCorr committed May 7, 2023
    Configuration menu
    Copy the full SHA
    80f320b View commit details
    Browse the repository at this point in the history

  4. add missing task descriptions

    @HeCorr
    HeCorr committed May 7, 2023
    Configuration menu
    Copy the full SHA
    0136e62 View commit details
    Browse the repository at this point in the history

  5. remove watch.sh dependency from watch task 

    Task can handle running tasks in parallel, so use that instead of relying on the `watch.sh` script which has shown to be incompatible with Task's interrupt signaling.

also update `watch` task's description.
    @HeCorr
    HeCorr committed May 7, 2023
    Configuration menu
    Copy the full SHA
    c898285 View commit details
    Browse the repository at this point in the history